-
Notifications
You must be signed in to change notification settings - Fork 5.4k
feat(metrics): track address_alert_response when transactions are added
#38570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
imblue-dabadee
wants to merge
6
commits into
main
Choose a base branch
from
feat(metrics)/track-address-alerts-when-tx-added
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(metrics): track address_alert_response when transactions are added
#38570
imblue-dabadee
wants to merge
6
commits into
main
from
feat(metrics)/track-address-alerts-when-tx-added
+73
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (2 files, +58 -0)
|
Collaborator
Builds ready [865e80c]
UI Startup Metrics (1201 ± 102 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
address_alert_response when transactions are addedaddress_alert_response when transactions are added
Collaborator
Builds ready [c898d6f]
UI Startup Metrics (1251 ± 96 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
INVALID-PR-TEMPLATE
PR's body doesn't match template
no-changelog
no-changelog Indicates no external facing user changes, therefore no changelog documentation needed
size-S
team-product-safety
Push issues to Product Safety team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The "Transaction Added" event was missing the
address_alert_responsefield, which made it difficult to analyze transaction flows by address security status from the initial event.Solution
Added
address_alert_responseto the initial "Transaction Added" event. The field includes:'Benign','Malicious')'Loading'if the scan is still in progress'not_applicable'when scanning cannot be performed (security alerts disabled, notoaddress, or unsupported chain)The
useTrustSignalMetricshook continues to update the event fragment with the final value once the scan completes.Changelog
CHANGELOG entry: null
Manual testing steps
address_alert_responseis present with one of:'Loading'(scan in progress)'Benign','Malicious','Warning'(scan result)'not_applicable'(security alerts disabled or unsupported chain)address_alert_responsevalue (should no longer be'Loading')Pre-merge author checklist
Pre-merge reviewer checklist
Note
Adds
address_alert_responseto transaction event properties, sourcing cached trust-signal results when available or marking asLoading/not_applicableas needed.address_alert_responseto properties built inbuildEventFragmentPropertiesfor "added", "approved", "submitted", and "finalized" flows.createCacheKey,mapChainIdToSupportedEVMChain,ResultType):result_typewhen present.Loadingornot_applicable(security alerts disabled, missingto, or unsupported chain).TransactionMetricsRequestwithgetAddressSecurityAlertResponse(cacheKey)andgetSecurityAlertsEnabled(); expose implementations inmetamask-controller.ScanAddressResponse) and utilities in metrics module.address_alert_responsein event properties.Written by Cursor Bugbot for commit c898d6f. This will update automatically on new commits. Configure here.